Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of the new command ZUNION #1502

Merged
merged 16 commits into from
Jun 22, 2023
Merged

Add support of the new command ZUNION #1502

merged 16 commits into from
Jun 22, 2023

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Jun 17, 2023

Fixes : #1461

@infdahai infdahai mentioned this pull request Jun 12, 2023
Closed
9 tasks
@uds5501 uds5501 marked this pull request as ready for review June 18, 2023 10:31
@PragmaTwice PragmaTwice requested review from git-hulk and torwig June 18, 2023 11:09
torwig
torwig reviewed Jun 19, 2023
View reviewed changes
src/commands/cmd_zset.cc Outdated Show resolved Hide resolved
@uds5501 uds5501 requested review from git-hulk and torwig June 19, 2023 17:00
@uds5501 uds5501 changed the title Feat: Implement zunion Feat: Implement ZUNION Jun 19, 2023
uds5501
uds5501 commented Jun 19, 2023
View reviewed changes
src/types/redis_zset.cc Outdated Show resolved Hide resolved
@git-hulk git-hulk changed the title Feat: Implement ZUNION Add support of the new command ZUNION Jun 21, 2023
@git-hulk git-hulk added feature type new feature release notes labels Jun 21, 2023
git-hulk
git-hulk reviewed Jun 21, 2023
View reviewed changes
src/types/redis_zset.cc Outdated Show resolved Hide resolved
git-hulk
git-hulk reviewed Jun 21, 2023
View reviewed changes
src/commands/cmd_zset.cc Outdated Show resolved Hide resolved
@uds5501 uds5501 requested review from PragmaTwice and git-hulk June 21, 2023 05:39
@uds5501 uds5501 requested a review from torwig June 21, 2023 08:43
torwig
torwig approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 5d675d0 into apache:unstable Jun 22, 2023
enjoy-binbin added a commit to enjoy-binbin/kvrocks that referenced this pull request Jul 6, 2023
@enjoy-binbin
Fix ZUNION hang in syntax error
898b5a1 
Bug introduce in apache#1502, without this return, when syntax
error happen, the code will stuck in the while loop and
result a hang.
@enjoy-binbin enjoy-binbin mentioned this pull request Jul 6, 2023
Merged
git-hulk pushed a commit that referenced this pull request Jul 7, 2023
@enjoy-binbin
Fix ZUNION hang in syntax error (#1559)
d39e198 
The bug was introduced in #1502, without this return, when syntax
the error happens, the code will be stuck in the while loop and
result in a hang.
@PragmaTwice PragmaTwice mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

@PragmaTwice PragmaTwice Awaiting requested review from PragmaTwice

Assignees
No one assigned
Labels
feature type new feature release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the support of the ZUNION command
4 participants
@uds5501 @git-hulk @torwig @PragmaTwice