Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lock guard movable & accept generalized arguments #1636

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Make lock guard movable & accept generalized arguments #1636

merged 3 commits into from
Aug 5, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Aug 4, 2023 •
edited
Loading

  • make LockManager::MultiGet and LockGuard accept arguments of more types (Slice, string_view, string...)
  • remove source file
  • make LockGuard and MultiLockGuard movable
  • move from storage/ to common/

@PragmaTwice PragmaTwice requested review from git-hulk and mapleFU August 4, 2023 22:52
mapleFU
mapleFU approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment •
edited by PragmaTwice
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is -clang-analyzer-cplusplus.InnerPointer a new rule here?

@PragmaTwice
Copy link
Member Author

PragmaTwice commented Aug 5, 2023 •
edited
Loading

is -clang-analyzer-cplusplus.InnerPointer a new rule here?

it is removed due to a false positive.
https://github.com/apache/kvrocks/actions/runs/5767527255/job/15637332818

@PragmaTwice PragmaTwice merged commit 04c5a92 into apache:unstable Aug 5, 2023
p1u3o pushed a commit to p1u3o/incubator-kvrocks that referenced this pull request Aug 15, 2023
@PragmaTwice @p1u3o
Make lock guard movable & accept generalized arguments (apache#1636)
96b5391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @mapleFU