Fix miscreating column families when opening with the readonly mode #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only mode Currently, kvrocks2redis will read and parse data from local DB with openning in readonly mode, and it will be failed if the Kvrocks is running on the same DB dir. The root cause is the running Kvrocks would acquire the DB lock and kvrocks2redis would try to acquire this DB lock as well when creating column familes.
mapleFU
approved these changes
Aug 6, 2023
PragmaTwice
approved these changes
Aug 6, 2023
enjoy-binbin
approved these changes
Aug 7, 2023
PragmaTwice
changed the title
p1u3o
pushed a commit
to p1u3o/incubator-kvrocks
that referenced
this pull request
Aug 15, 2023
…pache#1645) Currently, kvrocks2redis will read and parse data from the local DB with opening in read-only mode, and it will be failed if the Kvrocks is running on the same DB dir. The root cause is the running Kvrocks would acquire the DB lock and kvrocks2redis would try to acquire this DB lock as well when creating column families. Before applying this patch: ```shell ❯ ./kvrocks2redis -c kvrocks2redis.conf Version: unstable @6350d72 E20230806 23:46:56.435000 18548092 main.cc:151] Failed to create pidfile './kvrocks2redis.pid': File exists ``` After applying this patch: ```shell ❯ ./kvrocks2redis -c kvrocks2redis.conf Version: unstable @6350d72 Start parse increment batch ... ``` This fixes apache#1644.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, kvrocks2redis will read and parse data from the local DB
with opening in read-only mode, and it will be failed if the Kvrocks
is running on the same DB dir.
The root cause is the running Kvrocks would acquire the DB lock and
kvrocks2redis would try to acquire this DB lock as well when creating
column families.
Before applying this patch:
❯ ./kvrocks2redis -c kvrocks2redis.conf Version: unstable @6350d72 E20230806 23:46:56.435000 18548092 main.cc:151] Failed to create pidfile './kvrocks2redis.pid': File existsAfter applying this patch:
This fixes #1644.