Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hincrby/hincrbyfloat on wrong value and float precision check #168

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix hincrby/hincrbyfloat on wrong value and float precision check #168

merged 1 commit into from
Feb 3, 2021

Conversation

ShooterIT
Copy link
Member

Similar to #167

@ShooterIT ShooterIT marked this pull request as draft February 2, 2021 15:22
git-hulk
git-hulk approved these changes Feb 2, 2021
View reviewed changes
src/redis_hash.cc Outdated Show resolved Hide resolved
git-hulk
git-hulk previously approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShooterIT ShooterIT marked this pull request as ready for review February 3, 2021 04:53
@ShooterIT ShooterIT requested a review from git-hulk February 3, 2021 04:53
git-hulk
git-hulk approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 3c844ec into apache:master Feb 3, 2021
@ShooterIT ShooterIT mentioned this pull request Feb 8, 2021
Merged
@ShooterIT ShooterIT deleted the hincrby branch March 11, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShooterIT @git-hulk