Move sha1 and redis rand sources to vendor directory #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Aug 22, 2023
enjoy-binbin
approved these changes
Aug 22, 2023
mapleFU
approved these changes
Aug 22, 2023
|
cc @zncleon we can also use "vendor" directory to vendor the xxhash algorithm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a vendor directory for external headers and sources.
If an external source can be imported via CMake FetchContent without our modification, we just use FetchContent,
otherwise we need to put them to the vendor directory.
Currently we put sha1.h/cc rand.h/cc into the directory.