-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the random char seed to global rand to avoid collision #1729
Replace the random char seed to global rand to avoid collision #1729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, so thats GetCurrentTime
collision to many times...
I'll write a GetUUID64 instead. Lets check this in first
func RandString(min, max int, typ RandStringType) string {
return RandStringWithSeed(min, max, typ, rand.Int63())
} The change LGTM, however, would it better to change |
I changed the seed to rand.Int63. It's better than the time seed. |
#1727 changed the random string causing namespaces test fails.
This fixes #1728