Fix subscribe and unsubscribe command and pattern mode #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix subscribe and psubscribe command reply, the return number is the sum of subscription and psubscription - Fix unpsubscribe command operates on subscription data instead of psubscription - The unsubscribe and punsubscribe commands can operates on more than one channel and pattern - The unsubscribe and punsubscribe commands should have reply
karelrooted
requested changes
Feb 5, 2021
src/redis_cmd.cc
Outdated
| conn->UnSubscribeAll(); | ||
| SubscribeCommmandReply(output, "unsubscribe", "", | ||
| conn->SubscriptionsCount() + conn->PSubscriptionsCount()); |
There was a problem hiding this comment.
in unsubscribe all, a message for every unsubscribed channel will be sent to the client in stock redis (verified on redis v5.0.4)， is this response on purpose？
src/redis_cmd.cc
Outdated
| if (args_.size() == 1) { | ||
| conn->PUnSubscribeAll();; | ||
| SubscribeCommmandReply(output, "punsubscribe", "", | ||
| conn->SubscriptionsCount() + conn->PSubscriptionsCount()); |
There was a problem hiding this comment.
in punsubscribe all, a message for every punsubscribed channel_patten will be sent to the client in stock redis (verified on redis v5.0.4)， is this response on purpose？
There was a problem hiding this comment.
You are right, i miss that, please have a look again.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is the sum of subscription and psubscription
psubscription
one channel and pattern