Add the client name and ipport to the slowlog output #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
changed the title
git-hulk
reviewed
Sep 5, 2023
PragmaTwice
reviewed
Sep 5, 2023
|
Thanks for your contribution! Please refer to https://kvrocks.apache.org/community/contributing/ to format, lint and test your code. It is hard for us to merge it until the CI passes. BTW, it would be better to add golang test cases for slowlog changes. |
git-hulk
reviewed
Sep 6, 2023
|
Others are good to me, thank you! |
git-hulk
approved these changes
Sep 6, 2023
torwig
approved these changes
Sep 6, 2023
PragmaTwice
approved these changes
Sep 6, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1736