Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pointer-bool-conversion warning in GeoHashHelper::BoundingBox #1760

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Fix pointer-bool-conversion warning in GeoHashHelper::BoundingBox #1760

merged 1 commit into from
Sep 17, 2023

Conversation

gogim1
Copy link
Contributor

@gogim1 gogim1 commented Sep 16, 2023 •
edited
Loading

A warning is generated here:

address of array 'geo_shape->bounds' will always evaluate to 'true' [-Wpointer-bool-conversion]GCC

This PR fixes it.

@gogim1
fix pointer-bool-conversion warning
fb7969c 
Signed-off-by: gogim1 <294843472@qq.com>
git-hulk
git-hulk approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@git-hulk git-hulk merged commit 9f71709 into apache:unstable Sep 17, 2023
26 checks passed
@gogim1 gogim1 deleted the pointer-bool-conversion branch September 17, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gogim1 @git-hulk @torwig