Fix wrong replica's port number(=0) if the listening port is not set #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
reviewed
Sep 18, 2023
|
@xiaofan8421 Thanks for your good catch! Leave a comment inline. |
git-hulk
changed the title
torwig
force-pushed
the
bugfix/roy/info-slaves-peer-addr
branch
from
1d5f4d9 to
3dab859
Compare
|
@xiaofan8421 Hi, would you like to finish the final modification according to @git-hulk before the 2.6.0 cherry-picking period? (refer to #1767) If it can be merged before the deadline, it can be shipped to kvrocks 2.6.0 smoothly : ) If you are busy, we can help you to do that. |
xiaofan8421
force-pushed
the
bugfix/roy/info-slaves-peer-addr
branch
from
640ca10 to
b7df06e
Compare
Thanks for your mention. Update PR. Please review it. |
git-hulk
approved these changes
Sep 20, 2023
torwig
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
For some reason, I used Go to implement my slaves based on kvrocks. But by redis-cli to get replication-info from kvrocks(no matter what master/slave), the peer port is 0 which is wrong.
Reproduce:
Not only localhost but also the cross-machine can reproduce the bug scene.
So, I fixed it. Maybe it is not your code standard, Please review it.
before:
after: