Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow create-cluster to be run from other dirs, not just its own dir #1773

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Sep 21, 2023

The current harcode directory causes us to only run create-cluster
in the create-cluster directory. This PR makes it possible to run
create-cluster from any dir, not just its own dir.

local test:

[root@binblog incubator-kvrocks]# pwd
/root/kvrocks/incubator-kvrocks
[root@binblog incubator-kvrocks]# ./utils/create-cluster/create-cluster start
Starting 30001
instance port 30001 is not ready, will retry after 1 second
OK
OK
Starting 30002
instance port 30002 is not ready, will retry after 1 second
OK
OK
Starting 30003
instance port 30003 is not ready, will retry after 1 second
OK
OK
Starting 30004
instance port 30004 is not ready, will retry after 1 second
OK
OK
Starting 30005
instance port 30005 is not ready, will retry after 1 second
OK
OK
Starting 30006
instance port 30006 is not ready, will retry after 1 second
OK
OK

The current harcode directory causes us to only run create-cluster
in the create-cluster directory. This PR makes it possible to run
create-cluster from any dir, not just its own dir.
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great!

@enjoy-binbin enjoy-binbin merged commit 86abc21 into apache:unstable Sep 21, 2023
26 checks passed
@enjoy-binbin enjoy-binbin deleted the create_cluster_patch branch September 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants