Add more sanity checks for docker image #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
previously approved these changes
Nov 6, 2023
PragmaTwice
reviewed
Nov 6, 2023
| @@ -310,7 +310,18 @@ jobs: | |||
| tags: kvrocks:ci | |||
| outputs: type=docker | |||
| - name: Test built image | |||
| run: docker run --rm kvrocks:ci -v | |||
There was a problem hiding this comment.
I think we still need this one since it is not covered in the new checks.
There was a problem hiding this comment.
When starting kvrocks, the version is output but cannot be seen due to detach.
I have restored this version check to output the version to github action log.
PragmaTwice
approved these changes
Nov 8, 2023
git-hulk
approved these changes
Nov 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #1793.