Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add INFO comment when DB not scaned #1956

Merged
merged 8 commits into from
Jan 3, 2024
Merged

Add INFO comment when DB not scaned #1956

merged 8 commits into from
Jan 3, 2024

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Dec 19, 2023 •
edited
Loading

I noticed that many people are unaware that they need to run dbsize scan first in order to obtain the "keys num" information.

So I have added the logic: when dbsize scan has not been executed, the INFO command will display a warning to remind the user to run the dbsize scan command.

WARN: DB not scan, run `dbsize scan` command first.
db0:keys=0,expires=0,avg_ttl=0,expired=0

tisonkun
tisonkun previously approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

PragmaTwice
PragmaTwice reviewed Jan 2, 2024
View reviewed changes
src/server/server.cc Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Jan 2, 2024
View reviewed changes
src/server/server.cc Outdated Show resolved Hide resolved
jihuayu and others added 2 commits January 2, 2024 16:49
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit aaf0faf into apache:unstable Jan 3, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@git-hulk git-hulk git-hulk approved these changes

@tisonkun tisonkun tisonkun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jihuayu @git-hulk @tisonkun @PragmaTwice