-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor kvrocks2redis via rocksdb secondary instance #1963
Conversation
I'm still trying to add some integration tests |
Thanks for your contribution @maochongxin! The PR description is empty. Can you add some background so that reviewers can understand the motivation and how you plan to implement it? |
Thank you for the reminder. I have now provided the background information for this matter. |
Co-authored-by: Twice <twice@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good to me! It would be great if you can add some test for it.
Added test for data consistency between the source and destination nodes. |
Great! Could you also add tests for the incremental data? e.g. kvrocks2redis can catch new data after starting if it is written to the source kvrocks node. |
We need to add apache license header to newly added files.
Refer to x.py for the same header. |
Thank you, updated. |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 5 New issues |
Thank you for your contribution! |
Using RSI (Secondary Instance) for synchronization, replacing the previous method of using
OpenForReadOnly
followed by PSync.First, open the data directory using
OpenAsSecondary
, and reuse the previous method of parsing the checkpoint to complete a "full sync". Then, useTryCatchUpWithPrimary
to synchronize the new wal.Try to fix #1832