Implement the RESP3 null for the nil string and array #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR involves many files, but most of them are renaming the function. |
git-hulk
force-pushed
the
add-resp3-null
branch
from
b5881ee to
3df2070
Compare
git-hulk
requested review from
PragmaTwice,
torwig,
enjoy-binbin and
mapleFU
and removed request for
PragmaTwice
git-hulk
force-pushed
the
add-resp3-null
branch
from
86963fc to
a49c7fb
Compare
For the null type in RESP2, the nil string is represented by `$-1\r\n` and nil array is `*-1\r\n`. But after RESP3, they will be reduced into an unify string `_\r\n`. So in this PR, most of them are renamed redis::MultiBulkString/Redis::NilString to connection::MultiBulkString and connection::NilString.
git-hulk
force-pushed
the
add-resp3-null
branch
from
a49c7fb to
e239e83
Compare
torwig
previously approved these changes
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
PragmaTwice
reviewed
Jan 15, 2024
|
PragmaTwice
approved these changes
Jan 15, 2024
|
Thanks for @torwig @PragmaTwice review. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the null type in RESP2, the nil string is represented by
$-1\r\nand nil array is
*-1\r\n. But after RESP3, they will be reduced intoa unified string
_\r\n. So in this PR, most of them are renamed redis::MultiBulkString/Redis::NilString to connection::MultiBulkString and connection::NilString.This closes #1993