Implement the unify WAL iterator #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caipengbo
changed the title
caipengbo
changed the title
caipengbo
commented
Jan 23, 2024
|
Could you run If you've run it but the CI still fail in format check, please use clang-format with exact version 14. |
|
Ok, my machine clang-format is version 17, let me install version 14. |
git-hulk
reviewed
Jan 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2007
Implement the unify WAL iterator for kvrocks, similar to
DBIterator. It will wrap rocksdb WAL Iterator and can return different item types. It is possible to implement their processing logic depending on the concrete type.