Fix crash in zset store getkeys, fix zdiff/bzmpop range, add tests #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These following cases will crash the server, the reason is that the index of numkeys is wrong: ``` command getkeys zdiffstore dst 2 src1 src2 command getkeys zinterstore dst 2 src1 src2 command getkeys zunionstore dst 2 src1 src2 ``` These following getkeys output is wrong: ``` > command getkeys zdiff 2 key1 key2 1) "key1" 2) "key2" 3) (nil) > command getkeys bzmpop 0 2 key1 key2 1) "key1" ``` These are ok: ``` command getkeys zinter 2 key1 key2 command getkeys zunion 2 key1 key2 command getkeys sintercard 2 key1 key2 command getkeys zintercard 2 key1 key2 command getkeys zmpop 2 key1 key2 command getkeys lmpop 2 key1 key2 command getkeys blmpop 0 2 key1 key2 ``` However, at present, there is still a problem with our zset store. We do not support returning dst key, but let's do it later... ``` 127.0.0.1:6379> command getkeys zinterstore dst 2 src1 src2 1) "dst" 2) "src1" 3) "src2" 127.0.0.1:6666> command getkeys zinterstore dst 2 src1 src2 1) "src1" 2) "src2" ```
|
I think we need to inform developers that in versions of kvrocks before 2.8, some commands may cause server crashes. |
|
@jihuayu Thanks for your warm reminder. Yes we should mention this in our next release note. |
enjoy-binbin
added a commit
to enjoy-binbin/kvrocks
that referenced
this pull request
Jan 26, 2024
For store key related commands, we cannot extract the store key, see apache#2051. This PR adds store_key to CommandKeyRange to represent its index. This PR handle these store key commands: - zunionstore - zinterstore - zdiffstore - georadius - georadiusbymember - geosearchstore before: ``` > command getkeys zinterstore dst 2 src1 src2 1) "src1" 2) "src2" > command getkeys GEORADIUS src 1 1 1 km store dst 1) "src" > command getkeys GEORADIUSBYMEMBER src member radius m store dst 1) "src" > command getkeys GEOSEARCHSTORE dst src frommember member byradius 10 m 1) "dst" ``` after: ``` > command getkeys zinterstore dst 2 src1 src2 1) "dst" 2) "src1" 3) "src2" > command getkeys GEORADIUS src 1 1 1 km store dst 1) "src" 2) "dst" > command getkeys GEORADIUSBYMEMBER src member radius m store dst 1) "src" 2) "dst" > command getkeys GEOSEARCHSTORE dst src frommember member byradius 10 m 1) "dst" 2) "src" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These following cases will crash the server, the reason is that
the index of numkeys is wrong:
These following getkeys output is wrong:
These are ok:
However, at present, there is still a problem with our zset store.
We do not support returning dst key, but let's do it later...