Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage of std::move where compiler suggested #2099

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Feb 12, 2024

These warnings during the CI build with Clang should disappear.

/home/runner/work/kvrocks/kvrocks/src/config/config_type.h:167:27: warning: local variable 's' will be copied despite being returned by name [-Wreturn-std-move]
    if (!s.IsOK()) return s;
                          ^
/home/runner/work/kvrocks/kvrocks/src/config/config_type.h:167:27: note: call 'std::move' explicitly to avoid copying
    if (!s.IsOK()) return s;
                          ^
                          std::move(s)
1 warning generated.

Thanks to @aleksraiden for noticing.

Copy link

@git-hulk git-hulk merged commit eee6486 into apache:unstable Feb 13, 2024
30 checks passed
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants