Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump glog to 0.7.1 #2106

Merged
merged 28 commits into from
Nov 19, 2024
Merged

Conversation

aleksraiden
Copy link
Contributor

@aleksraiden aleksraiden commented Feb 18, 2024

Update google log to 0.7.0. Full release notes here: https://github.com/google/glog/releases/tag/v0.7.0
Also, included update 0.7.1 (see here: https://github.com/google/glog/releases/tag/v0.7.1)

Key features

  • C++14 is now the primary language standard
  • google::EnableLogCleaner(unsigned) has been superseded by google::EnableLogCleaner(std::chrono::minutes)
  • google::LogSeverity has been converted to an unscoped enum. This can result in compilation issues if implicit conversion between an int and google::LogSeverity was erroneously assumed.
  • A lot of fixes and enhancements (see full changelog)

Code changes

At this update we need to fix our codebase to have full comparability with this and futures release of glog. Thanks @torwig for this fixes.

  • Fix google::EnableLogCleaner (done)
  • Fix linting and code checks (done)
  • Fix google::LogSeverity (done)
  • Fix a symbolizes a program counter (in progress)

@aleksraiden
Copy link
Contributor Author

aleksraiden commented Feb 18, 2024

Now we have unresolved issue at build kvrocks:

[100%] Linking CXX executable kvrocks
/usr/sbin/ld: CMakeFiles/kvrocks.dir/src/cli/main.cc.o: in function SegvHandler': /__w/kvrocks/kvrocks/src/cli/signal_util.h:54:(.text.SegvHandler[SegvHandler]+0x266): undefined reference to google::Symbolize(void*, char*, unsigned long)'
collect2: error: ld returned 1 exit status

@torwig
Copy link
Contributor

torwig commented Feb 18, 2024

google::Symbolize isn't exported anymore in 0.7.0 so we need to use something else for our purposes (or ask the maintainers of GLOG to export it again :) ).

@PragmaTwice PragmaTwice changed the title Bump glog to 0.7.0 Bump glog to 0.7.1 Jun 9, 2024
@aleksraiden aleksraiden changed the title Bump glog to 0.7.1 chore: Bump glog to 0.7.1 Jun 9, 2024
@aleksraiden aleksraiden marked this pull request as ready for review June 9, 2024 15:05
src/cli/main.cc Outdated Show resolved Hide resolved
src/config/config.cc Outdated Show resolved Hide resolved
@aleksraiden
Copy link
Contributor Author

Hmm, I think (thanks, @torwig) that in failed gotest kvrocks not starting yet. Need to investigate this

@aleksraiden aleksraiden changed the title chore: Bump glog to 0.7.1 [DNM[ Bump glog to 0.7.1 Nov 11, 2024
@aleksraiden aleksraiden marked this pull request as draft November 11, 2024 11:38
aleksraiden and others added 3 commits November 17, 2024 13:58
Awoid a compile warning: comparison of integer expressions of different signedness: ‘const int’ and ‘const size_t’
@PragmaTwice PragmaTwice changed the title [DNM[ Bump glog to 0.7.1 [DNM] Bump glog to 0.7.1 Nov 17, 2024
@aleksraiden aleksraiden marked this pull request as ready for review November 17, 2024 11:03
@aleksraiden aleksraiden changed the title [DNM] Bump glog to 0.7.1 chore: bump glog to 0.7.1 Nov 17, 2024
@aleksraiden
Copy link
Contributor Author

Great thanks to @torwig about rewrite a gotest for logger. Wuuf, now a longest PR ready to review

@git-hulk
Copy link
Member

@aleksraiden Great!

@PragmaTwice PragmaTwice merged commit 88ac233 into apache:unstable Nov 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants