Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the type is an entry while iterating the stream subkeys #2112

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Check if the type is an entry while iterating the stream subkeys #2112

merged 4 commits into from
Feb 23, 2024

Conversation

jihuayu
Copy link
Member

@jihuayu jihuayu commented Feb 23, 2024

fixed #2109

@jihuayu jihuayu requested a review from Yangsx-1 February 23, 2024 01:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
81.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Yangsx-1
Yangsx-1 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Yangsx-1 Yangsx-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@git-hulk git-hulk changed the title Add subkey type judge for stream range and len function Check if the type is an entry while iterating the stream subkeys Feb 23, 2024
@git-hulk git-hulk merged commit 8a19bd5 into apache:unstable Feb 23, 2024
30 checks passed
@jihuayu jihuayu deleted the f/ok branch February 23, 2024 05:42
JoverZhang pushed a commit to JoverZhang/kvrocks that referenced this pull request Feb 24, 2024
@jihuayu @JoverZhang
Check if the type is an entry while iterating the stream subkeys (apa…
7b88f51 
…che#2112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yangsx-1 Yangsx-1 Yangsx-1 approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create stream consumer group will make the xread command error
3 participants
@jihuayu @git-hulk @Yangsx-1