Fix build warnings: local variable 's' will be copied despite being returned by name #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warning at build like:
```
[ 85%] Building CXX object CMakeFiles/kvrocks_objs.dir/src/cluster/slot_import.cc.o
/Users/runner/work/kvrocks/kvrocks/src/cluster/replication.cc:78:10: warning: local variable 's' will be copied despite being returned by name [-Wreturn-std-move]
return s;
^
/Users/runner/work/kvrocks/kvrocks/src/cluster/replication.cc:78:10: note: call 'std::move' explicitly to avoid copying
return s;
^
std::move(s)
[ 85%] Building CXX object CMakeFiles/kvrocks_objs.dir/src/cluster/slot_migrate.cc.o
[ 85%] Building CXX object CMakeFiles/kvrocks_objs.dir/src/cluster/sync_migrate_context.cc.o
```
aleksraiden
changed the title
…apache/kvrocks into aleksraiden-fix-warning-build-1
PragmaTwice
approved these changes
Mar 10, 2024
git-hulk
approved these changes
Mar 10, 2024
mapleFU
reviewed
Mar 10, 2024
| @@ -75,7 +75,7 @@ Status FeedSlaveThread::Start() { | |||
| conn_ = nullptr; // prevent connection was freed when failed to start the thread | |||
| } | |||
|
|
|||
| return s; | |||
| return std::move(s); | |||
There was a problem hiding this comment.
Hmm C++17 would applying nrvo for this ? @PragmaTwice
There was a problem hiding this comment.
The type of returned value is not the same as the return type. So no.
|
mapleFU
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning at build like: