Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rocksdb to v9.1.1 #2254

Closed
wants to merge 7 commits into from
Closed

Conversation

aleksraiden
Copy link
Contributor

@aleksraiden aleksraiden commented Apr 18, 2024

Bump rocksdb to 9.1.0. Full release notes - https://github.com/facebook/rocksdb/releases/tag/v9.1.0

Key features:

  • On file systems that support storage level data checksum and reconstruction, retry SST block reads for point lookups, scans, and flush and compaction if there's a checksum mismatch on the initial read
  • Some enhancements and fixes to experimental Temperature handling features
  • WriteBatchWithIndex now supports wide-column point lookups via the GetEntityFromBatch API
  • Best-effort recovery (best_efforts_recovery == true) may now be used together with atomic flush (atomic_flush == true). The all-or-nothing recovery guarantee for atomically flushed data will be upheld.
  • Remove deprecated option bottommost_temperature, already replaced by last_level_temperature
  • Added new PerfContext counters for block cache bytes read - block_cache_index_read_byte, block_cache_filter_read_byte, block_cache_compression_dict_read_byte, and block_cache_read_byte.
  • Deprecate experimental Remote Compaction APIs
  • Defined a new PerfLevel kEnableWait to measure time spent by user threads blocked in RocksDB other than mutex, such as a write thread waiting to be added to a write group, a write thread delayed or stalled etc.
  • RateLimiter's API no longer requires the burst size to be the refill size
  • Fixed kBlockCacheTier reads to return Status::Incomplete
  • Fixed a data race in WalManager
  • Re-enable the recycle_log_file_num option in DBOptions for kPointInTimeRecovery WAL recovery mode, which was previously disabled due to a bug in the recovery logic. This option is incompatible with WriteOptions::disableWAL. A Status::InvalidArgument() will be returned if disableWAL is specified.
  • Java API multiGet() variants now take advantage of the underlying batched multiGet() performance improvements.

Bump v9.1.1 bugfix:

  • Fixed a regression when ColumnFamilyOptions::max_successive_merges > 0 where the CPU overhead for deciding whether to merge could have increased unless the user had set the option ColumnFamilyOptions::strict_max_successive_merges

@aleksraiden aleksraiden changed the title Bump rocksdb to v9.1.0 Bump rocksdb to v9.1.1 Apr 23, 2024
@aleksraiden
Copy link
Contributor Author

Update: bump rocksdb to 9.1.1 (bugfix release - https://github.com/facebook/rocksdb/releases/tag/v9.1.1)

  • Fixed a regression when ColumnFamilyOptions::max_successive_merges > 0 where the CPU overhead for deciding whether to merge could have increased unless the user had set the option ColumnFamilyOptions::strict_max_successive_merges

@torwig
Copy link
Contributor

torwig commented Apr 30, 2024

@git-hulk @PragmaTwice I need your superpower here when you have time. Please take a look at the build error. I tried to figure out the reason but failed. Just a regular RocksDB code was changed between 9.1.0 and 9.1.1 but the error somehow appeared.

@git-hulk
Copy link
Member

@torwig Sure, thanks for your investigation. I'm not sure if it's related to the musl library since other CI cases are good. Will take a look when I get time, maybe @PragmaTwice is an expert on this 😎

@aleksraiden
Copy link
Contributor Author

aleksraiden commented May 2, 2024

Maybe can help us - jemalloc/jemalloc#778 and google/tcmalloc#150 (but tmalloc)

@aleksraiden
Copy link
Contributor Author

I'am fixed this bug, create at separate PR

@aleksraiden
Copy link
Contributor Author

Now we can try update from upstream and check it

@aleksraiden
Copy link
Contributor Author

Hmm, not working, like a mystic )

@mapleFU
Copy link
Member

mapleFU commented May 11, 2024

#2298 (comment)

I've meet this issue in rocksdb, sigh...Maybe we should shift to a new version later?

@aleksraiden
Copy link
Contributor Author

#2298 (comment)

I've meet this issue in rocksdb, sigh...Maybe we should shift to a new version later?

Yeah, I'am waiting an next release of rocksdb at a week... and update PR

@aleksraiden aleksraiden marked this pull request as draft May 14, 2024 07:04
@PragmaTwice
Copy link
Member

succeeded by #2327.

@tisonkun tisonkun deleted the aleksraiden-rocksdb-9.1.0 branch June 1, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants