Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stream): add support of XPENDING command #2387

Merged
merged 8 commits into from
Jul 21, 2024
Merged

feat(stream): add support of XPENDING command #2387

merged 8 commits into from
Jul 21, 2024

Conversation

Yangsx-1
Copy link
Contributor

Close #1734

git-hulk
git-hulk previously approved these changes Jul 1, 2024
View reviewed changes
torwig
torwig reviewed Jul 1, 2024
View reviewed changes
src/types/redis_stream.cc Outdated Show resolved Hide resolved
torwig
torwig previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Ideally, it would be great to add the test case for the filtering by IDLE time.

@Yangsx-1
Copy link
Contributor Author

Yangsx-1 commented Jul 1, 2024

LGTM. Ideally, it would be great to add the test case for the filtering by IDLE time.

Will add it in another PR. :)

@PragmaTwice
Copy link
Member

After #2384, I think this command need to be refactored.

So it's better to review and merge #2384 before this PR.

@PragmaTwice
Copy link
Member

#2384 is merged, could you refactor this PR to avoid iterating the whole stream subkeys?

@Yangsx-1
Copy link
Contributor Author

#2384 is merged, could you refactor this PR to avoid iterating the whole stream subkeys?

Sure, will do it later.

torwig
torwig reviewed Jul 17, 2024
View reviewed changes
src/types/redis_stream.cc Show resolved Hide resolved
src/types/redis_stream.cc Show resolved Hide resolved
@PragmaTwice PragmaTwice requested a review from torwig July 20, 2024 06:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.4% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice merged commit 68523ac into apache:unstable Jul 21, 2024
30 checks passed
@Yangsx-1 Yangsx-1 deleted the xpending branch July 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of the XPENDING command
4 participants
@Yangsx-1 @PragmaTwice @git-hulk @torwig