Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use official typos github action #2388

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

shoothzj
Copy link
Member

create-ci/typos is whitelisted in https://issues.apache.org/jira/browse/INFRA-25798. I propose to switch, using official github actions will have better interactions in github PR.

@git-hulk
Copy link
Member

git-hulk commented Jun 30, 2024

@shoothzj Thanks for your contribution. Seems the configuration file didn't take effect.

@shoothzj
Copy link
Member Author

@git-hulk Thanks for your quick reply, I will figure out it why :)

@shoothzj
Copy link
Member Author

shoothzj commented Jun 30, 2024

@git-hulk Why do you think configuration not works? I guess ci is failed because I bump the typos-check version also, I can also fix new typos in this PR.

I debug this actions in my fork repo. It seems paas dir successfully.

https://github.com/shoothzj/kvrocks/actions/runs/9732469130/job/26858166901

2024-06-30 13:42:57 (250 MB/s) - ‘typos-v1.22.9-x86_64-unknown-linux-musl.tar.gz’ saved [5575207/5575207]

./typos
jq: jq-1.6
$ ./typos . --config ./.github/config/typos.toml
Warning: "arange" should be "arrange".
Warning: "arange" should be "arrange".

@git-hulk
Copy link
Member

git-hulk commented Jun 30, 2024

@git-hulk Why do you think configuration not works? I guess ci is failed because I bump the typos-check version also, I can also fix new typos in this PR.

I debug this actions in my fork repo. It seems paas dir successfully.

https://github.com/shoothzj/kvrocks/actions/runs/9732469130/job/26858166901

2024-06-30 13:42:57 (250 MB/s) - ‘typos-v1.22.9-x86_64-unknown-linux-musl.tar.gz’ saved [5575207/5575207]

./typos
jq: jq-1.6
$ ./typos . --config ./.github/config/typos.toml
Warning: "arange" should be "arrange".
Warning: "arange" should be "arrange".

@shoothzj Thanks for your investigation. I found those typos weren't found before, so I'm wondering if the configuration wasn't set correctly before this PR. But maybe I was wrong since it uses different versions of typos.

@tisonkun
Copy link
Member

since it uses different versions of typos

This is the reason. Typos update its vocabulary about each month.

@PragmaTwice
Copy link
Member

PragmaTwice commented Jun 30, 2024

We can rename arange to a_range.

@shoothzj shoothzj marked this pull request as draft July 1, 2024 00:33
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@shoothzj shoothzj marked this pull request as ready for review July 1, 2024 00:56
@shoothzj
Copy link
Member Author

shoothzj commented Jul 1, 2024

@git-hulk @PragmaTwice I downgraded the version, I think we can merge this first. As for arange brange, I will send a patch later this week.

@git-hulk git-hulk requested review from tisonkun and PragmaTwice July 1, 2024 02:03
Copy link

sonarqubecloud bot commented Jul 1, 2024

@tisonkun tisonkun merged commit 12067d9 into apache:unstable Jul 1, 2024
29 checks passed
@tisonkun
Copy link
Member

tisonkun commented Jul 1, 2024

Thanks for your contribution!

@shoothzj shoothzj deleted the typos-action branch July 1, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants