Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): implement vector query for sql/redisearch parser & transformer #2450

Merged
merged 12 commits into from
Aug 2, 2024
Merged

feat(search): implement vector query for sql/redisearch parser & transformer #2450

merged 12 commits into from
Aug 2, 2024

Conversation

Beihao-Zhou
Copy link
Member

@Beihao-Zhou Beihao-Zhou commented Jul 28, 2024 •
edited
Loading

This PR is part of #2426

Summary

  • Hnsw Vector Redis Query Parser & Transformer (i.e. KNN & Range)
  • Hnsw Vector SQL Query Parser & Transformer (i.e. KNN & Range)
  • Handle vector input (including blob and string representation)

References

@Beihao-Zhou Beihao-Zhou mentioned this pull request Jul 28, 2024
Open
12 tasks
PragmaTwice
PragmaTwice reviewed Jul 28, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Jul 28, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
@Beihao-Zhou
Copy link
Member Author

@PragmaTwice Ready for review now!
I'm not sure if there are better solutions for the unified abstraction to handle vector parsing. Let me know if you see any room of improvement! Thx! <3

@Beihao-Zhou Beihao-Zhou marked this pull request as ready for review July 30, 2024 07:54
PragmaTwice
PragmaTwice reviewed Jul 31, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Jul 31, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Jul 31, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Jul 31, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Aug 1, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Aug 1, 2024
View reviewed changes
src/search/ir.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice reviewed Aug 1, 2024
View reviewed changes
src/search/sql_parser.h Outdated Show resolved Hide resolved
PragmaTwice
PragmaTwice approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@PragmaTwice PragmaTwice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thank you!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@PragmaTwice PragmaTwice changed the title feat(search): Hnsw Vector Query Parser & Transformer feat(search): implement vector query for sql/redisearch parser & transformer Aug 2, 2024
@PragmaTwice PragmaTwice merged commit 0f5f18e into apache:unstable Aug 2, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Beihao-Zhou @PragmaTwice