Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hyperloglog): Add support of PFMERGE command #2457

Merged
merged 8 commits into from
Aug 1, 2024
Merged

feat(hyperloglog): Add support of PFMERGE command #2457

merged 8 commits into from
Aug 1, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jul 31, 2024

No description provided.

git-hulk
git-hulk reviewed Jul 31, 2024
View reviewed changes
src/commands/cmd_hll.cc Outdated Show resolved Hide resolved
@mapleFU mapleFU requested review from git-hulk and PragmaTwice July 31, 2024 15:40
@mapleFU mapleFU mentioned this pull request Jul 31, 2024
Open
9 tasks
@git-hulk
Copy link
Member

git-hulk commented Aug 1, 2024

Generally looks good to me, only one comment inline.

git-hulk
git-hulk approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 1, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
59.7% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarCloud

@PragmaTwice PragmaTwice changed the title feat(HyperLogLog): Add PFMerge command support feat(hyperloglog): Add PFMERGE command support Aug 1, 2024
@PragmaTwice PragmaTwice changed the title feat(hyperloglog): Add PFMERGE command support feat(hyperloglog): Add support of PFMERGE command Aug 1, 2024
@PragmaTwice PragmaTwice merged commit a3863f9 into apache:unstable Aug 1, 2024
34 checks passed
@mapleFU mapleFU deleted the hll-pfmerge branch August 1, 2024 12:58
@PragmaTwice PragmaTwice mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapleFU @git-hulk @PragmaTwice