fix(config): wrong rocksdb config name max_sub_compactions #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
previously approved these changes
Aug 20, 2024
ChrisZMF
force-pushed
the
fix-max-subcompactions-dev
branch
from
87cf77d to
3f3c855
Compare
git-hulk
changed the title
git-hulk
changed the title
|
Unit tests can cover this scenario. The reason why unit test was ineffective before is that callback was not registered for the item, which means |
|
We can first checkin, and adding a cfg testing, and everyone we add a new config, a go-side cfg test should be added to cover the case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration
item rocksdb.max_sub_compactionsshould berocksdb.max_subcompactions.Try set
rocksdb.max_sub_compactions:Fix it as
rocksdb.max_subcompactions, try again: