fix(test): use fixed seed to improve reproducibility. #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beihao-Zhou
reviewed
Sep 26, 2024
src/search/hnsw_indexer.h
Outdated
Comment on lines
95
to
98
| HnswIndex(const SearchKey& search_key, HnswVectorFieldMetadata* vector, engine::Storage* storage, | ||
| std::random_device::result_type seed); | ||
| HnswIndex(const SearchKey& search_key, HnswVectorFieldMetadata* vector, engine::Storage* storage) | ||
| : HnswIndex(search_key, vector, storage, std::random_device()()) {} |
There was a problem hiding this comment.
Maybe we can use a single constructor with a default argument?
HnswIndex(const SearchKey& search_key,
HnswVectorFieldMetadata* vector,
engine::Storage* storage,
std::random_device::result_type seed = std::random_device()())
{
...
}
There was a problem hiding this comment.
Hi @Beihao-Zhou ,
Thanks for your review suggestions!
I have updated related constructors. 😊
Best Regards,
Edward
|
The rest LGTM :) |
git-hulk
approved these changes
Sep 27, 2024
|
PragmaTwice
approved these changes
Sep 27, 2024
Beihao-Zhou
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix: #2550
Unit test's random generation may make result unstable to expected result.
Proposed Changes
Use fixed seed for hnsw index unit test for improving reproducibility.