fix(json): JSON.MSET may update on the old json value #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragmaTwice
reviewed
Oct 5, 2024
git-hulk
reviewed
Oct 5, 2024
There was a problem hiding this comment.
@poipoiPIO Thanks for your contribution. This PR looks good to me except for adding some comments to explain the reason.
Co-authored-by: hulk <hulk.website@gmail.com> Co-authored-by: Twice <twice@apache.org>
git-hulk
changed the title
git-hulk
previously approved these changes
Oct 5, 2024
PragmaTwice
previously approved these changes
Oct 5, 2024
PragmaTwice
reviewed
Oct 5, 2024
Co-authored-by: Twice <twice@apache.org>
git-hulk
approved these changes
Oct 5, 2024
PragmaTwice
approved these changes
Oct 5, 2024
|
2 tasks
|
Thank y'all for the review! |
git-hulk
added a commit
that referenced
this pull request
Oct 18, 2024
…ctly (#2579) Co-authored-by: hulk <hulk.website@gmail.com> Co-authored-by: Twice <twice@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #2552, suggested by @VIVALXH
Summary:
This PR extends the JSON.MSet method by temporarily storing modified JSON objects in memory to prevent multiple data rewrites performed on a single key and only then writing the resulting key objects to the batch.