fix(cluster): should remove the master if it's not node in the cluster #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the replica won't remove the master replication while it's not a node in the clsuter, which an unexpcted behavior for the living master node in the cluster.
|
When would "master is not a node in cluster" happens? |
oh, this issue is caused by the replica instead of the master was removed in the cluster, but its replication is still living. |
|
caipengbo
approved these changes
Nov 4, 2024
mapleFU
approved these changes
Nov 4, 2024
Comment on lines
+206
to
209
| return s.Prefixed("failed to set master-replica replication"); | ||
| } | ||
|
|
||
| // Clear data of migrated slots |
There was a problem hiding this comment.
should here check myself_ == nullptr and skip checking for:
if (!migrated_slots_.empty()) {
engine::Context ctx(srv_->storage);
for (const auto &[slot, _] : migrated_slots_) {
if (slots_nodes_[slot] != myself_) {
auto s = srv_->slot_migrator->ClearKeysOfSlotRange(ctx, kDefaultNamespace, SlotRange::GetPoint(slot));
if (!s.ok()) {
LOG(ERROR) << "failed to clear data of migrated slots: " << s.ToString();
}
}
}
}
There was a problem hiding this comment.
I prefer keeping the previous behavior here since it should clear the keys of migrating slots once removed from the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the replica won't remove the master replication
while it's not a node in the cluster, which is an unexpected behavior
for the living master node in the cluster.
This fixes #2618.