test(integration): add integration test for master lost during syncing sst files. #2691
Conversation
LindaSummer
force-pushed
the
test/2662
branch
from
bbfb73f to
f5abeb8
Compare
|
Hi, I'm not sure my case is correctly covered the scenario in related issue. I only got about 1 second delay in my own machine. Please let me know if there is any problem about the test case. 😊 Best Regards, |
|
| start := time.Now() | ||
| require.NoError(t, replicaClient.Do(ctx, "clusterx", "SETNODES", unexistNodesInfo, "2").Err()) | ||
| duration := time.Since(start) | ||
| require.Less(t, duration, time.Second*6) |
There was a problem hiding this comment.
Why the time out is 5000/5100 but the duration be 6 here 🤔
There was a problem hiding this comment.
Hi @mapleFU ,
The time duration may not be a precise value due to network.
So I reserved 1 second to reduce flaky failure. 😊
Best Regards,
Edward
There was a problem hiding this comment.
What would a duration really looks like? Would it:
- Force greater than 5?
- Always less than 6? (I guess this is not guranteed ...)
There was a problem hiding this comment.
Hi @mapleFU ,
Yes, I thought it should be in a [5, 6 or longer] range.
But I only got about one second in my own environment and make me confused and not sure whether the case full covers the issue. 🤔
Maybe we can set the upper bound to a conservative value just for integration test. 😊
Best Regards,
Edward
There was a problem hiding this comment.
But I only got about one second in my own environment and make me confused and not sure whether the case full covers the issue. 🤔
Thanks! I'll dive in my env later, we can first move forward
Issue
Close #2671
Proposed Changes
Add integration test for losing master during SST file syncing.
Here is the steps.