Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rename-command config #272

Merged
merged 5 commits into from
May 26, 2021

Conversation

karelrooted
Copy link
Contributor

No description provided.

@karelrooted karelrooted requested review from git-hulk and ShooterIT May 20, 2021 07:50
@karelrooted karelrooted force-pushed the feature/rename-command branch 2 times, most recently from a7408e5 to 0c6fa79 Compare May 20, 2021 08:06
@karelrooted karelrooted marked this pull request as draft May 20, 2021 08:15
@karelrooted karelrooted force-pushed the feature/rename-command branch from 0c6fa79 to a378962 Compare May 20, 2021 08:24
@karelrooted karelrooted marked this pull request as ready for review May 20, 2021 08:24
@karelrooted karelrooted force-pushed the feature/rename-command branch from a378962 to aaf8fd8 Compare May 20, 2021 08:42
src/config.cc Outdated Show resolved Hide resolved
src/config.h Outdated Show resolved Hide resolved
karelrooted and others added 2 commits May 25, 2021 15:31
Co-authored-by: Wang Yuan <wangyuancode@163.com>
@karelrooted karelrooted force-pushed the feature/rename-command branch from 17c6317 to 1845b47 Compare May 25, 2021 07:32
@karelrooted karelrooted marked this pull request as draft May 25, 2021 08:27
@karelrooted karelrooted marked this pull request as ready for review May 25, 2021 08:27
@karelrooted karelrooted force-pushed the feature/rename-command branch from 1845b47 to 253d9cd Compare May 25, 2021 08:58
@karelrooted karelrooted force-pushed the feature/rename-command branch from 253d9cd to 8235253 Compare May 25, 2021 09:08
git-hulk
git-hulk previously approved these changes May 25, 2021
src/config.cc Outdated Show resolved Hide resolved
kvrocks.conf Outdated Show resolved Hide resolved
src/config.cc Show resolved Hide resolved
@ShooterIT
Copy link
Member

@karelrooted And could you supplement some tcl tests

ShooterIT
ShooterIT previously approved these changes May 26, 2021
git-hulk
git-hulk previously approved these changes May 26, 2021
@karelrooted karelrooted dismissed stale reviews from git-hulk and ShooterIT via 49a54ff May 26, 2021 07:12
@karelrooted
Copy link
Contributor Author

karelrooted commented May 26, 2021

@karelrooted And could you supplement some tcl tests

add a rename one command testcase, the current code base will not allow a multi rename-command directive, so rename-two-command testcase is not included

@karelrooted karelrooted merged commit fbd7372 into apache:unstable May 26, 2021
ShooterIT pushed a commit to ShooterIT/kvrocks that referenced this pull request Jul 15, 2021
* Add rename-command config
* Add rename-command config directive testcase
@ShooterIT ShooterIT mentioned this pull request Jul 15, 2021
ShooterIT pushed a commit that referenced this pull request Jul 19, 2021
* Add rename-command config
* Add rename-command config directive testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature type new feature release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants