Fix zset can't add the same member with different scores #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for @smartlee finding this issue |
Fix the corner case that adds the same member which may add the score column family many times and cause problems in the ZRANGE command. For example, we add members with `ZADD mykey 1 a 2 a` and `ZRANGE mykey 0 1` return only one member(`a`) was expected but got the member `a` twice now. The root cause of this issue was the score key was composed by member and score, so the last one can't overwrite the previous when the score was different. A simple workaround was add those members with reversed order and skip the member if has added.
ShooterIT
previously approved these changes
Jun 7, 2021
karelrooted
previously approved these changes
Jun 7, 2021
ShooterIT
changed the title
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jul 15, 2021
Fix the corner case that adds the same member which may add the score column family many times and cause problems in the ZRANGE command. For example, we add members with `ZADD mykey 1 a 2 a` and `ZRANGE mykey 0 1` return only one member(`a`) was expected but got the member `a` twice now. The root cause of this issue was the score key was composed by member and score, so the last one can't overwrite the previous one when the score was different. A simple workaround was to add those members with reversed orders and skip the member if has added.
Merged
ShooterIT
pushed a commit
that referenced
this pull request
Jul 19, 2021
Fix the corner case that adds the same member which may add the score column family many times and cause problems in the ZRANGE command. For example, we add members with `ZADD mykey 1 a 2 a` and `ZRANGE mykey 0 1` return only one member(`a`) was expected but got the member `a` twice now. The root cause of this issue was the score key was composed by member and score, so the last one can't overwrite the previous one when the score was different. A simple workaround was to add those members with reversed orders and skip the member if has added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the corner case that adds the same member which may add the score
column family many times and cause problems in the ZRANGE command.
For example, we add members with
ZADD mykey 1 a 2 aandZRANGE mykey 0 1return only one member(
a) was expected but got the memberatwice now.The root cause of this issue was the score key was composed by member and score,
so the last one can't overwrite the previous when the score was different.
A simple workaround was add those members with reversed order and skip the member if has added.