Remove exposing slot-id-encoded config #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Jul 15, 2021
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jul 16, 2021
Before, we expose slot-id-encoded in config file, that is useful to migrate keys based on slot when cluster is enabled, actually, we should only enable slot-id-encoded when we want to use cluster mode. So exposing this config may make users confused, and wrong config also make data corrupt. Now we remove this config, and set it automatically.
Merged
ShooterIT
added a commit
that referenced
this pull request
Jul 19, 2021
Before, we expose slot-id-encoded in config file, that is useful to migrate keys based on slot when cluster is enabled, actually, we should only enable slot-id-encoded when we want to use cluster mode. So exposing this config may make users confused, and wrong config also make data corrupt. Now we remove this config, and set it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we expose
slot-id-encodedin config file, that is useful to migrate keys based on slot when cluster is enabled, actually, we should only enableslot-id-encodedwhen we want to use cluster mode. So exposing this config may make users confused, and wrong config also make data corrupt .