Metadata and subkey column family share a singleblock cache #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, really a good feature. |
ShooterIT
requested changes
Sep 24, 2021
ShooterIT
approved these changes
Sep 24, 2021
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Nov 2, 2021
Merged
ShooterIT
pushed a commit
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
metadataColumn Family andsubkeyColumn Family have their own block cache, so block cache must be allocated in advance for the two CFs.It is not possible to predict the usage of the two CFs and allocate the optimal capacity for the two block caches, so we can provide a configuration item that specifies whether the two CFs should share a single block cache (see rocksdb Wiki).
Regarding this configuration item, although it is not an item for Rocksdb Option, it is related to Rocksdb, so I gave it a name prefixed with
rocksdb..