Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rocksdb.share_metadata_and_subkey_block_cache to yes by default #373

Merged
merged 1 commit into from
Oct 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kvrocks.conf
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ rocksdb.subkey_block_cache_size 2048
# if set 'yes'. The capacity of shared block cache is
# metadata_block_cache_size + subkey_block_cache_size
#
# Default: no
rocksdb.share_metadata_and_subkey_block_cache no
# Default: yes
rocksdb.share_metadata_and_subkey_block_cache yes

# Number of open files that can be used by the DB. You may need to
# increase this if your database has a large working set. Value -1 means
Expand Down
2 changes: 1 addition & 1 deletion src/config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ Config::Config() {
{"rocksdb.subkey_block_cache_size", true, new IntField(&RocksDB.subkey_block_cache_size, 2048, 0, INT_MAX)},
{"rocksdb.metadata_block_cache_size", true, new IntField(&RocksDB.metadata_block_cache_size, 2048, 0, INT_MAX)},
{"rocksdb.share_metadata_and_subkey_block_cache",
true, new YesNoField(&RocksDB.share_metadata_and_subkey_block_cache, false)},
true, new YesNoField(&RocksDB.share_metadata_and_subkey_block_cache, true)},
{"rocksdb.compaction_readahead_size", false, new IntField(&RocksDB.compaction_readahead_size, 2*MiB, 0, 64*MiB)},
{"rocksdb.level0_slowdown_writes_trigger",
false, new IntField(&RocksDB.level0_slowdown_writes_trigger, 20, 1, 1024)},
Expand Down