Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support executing INFO command during restoring database #375

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

ShooterIT
Copy link
Member

@ShooterIT ShooterIT commented Oct 19, 2021

Currently, we can't execute INFO command during restoring database on kvrocks,
but redis can. Kvrocks returns error messages directly, it is not easy for some
SDK/proxy/tools to check loading or other status, so this commit implements.

@ShooterIT ShooterIT requested a review from git-hulk October 19, 2021 09:03
git-hulk
git-hulk previously approved these changes Oct 19, 2021
src/server.cc Outdated Show resolved Hide resolved
@ShooterIT ShooterIT marked this pull request as draft October 20, 2021 06:49
@ShooterIT ShooterIT marked this pull request as ready for review January 7, 2022 02:54
@ShooterIT
Copy link
Member Author

Tests will be added in the next PR.

@ShooterIT ShooterIT requested a review from git-hulk January 7, 2022 03:30
@ShooterIT ShooterIT merged commit 4acf444 into apache:unstable Jan 7, 2022
@ShooterIT ShooterIT deleted the info-loading-ok branch January 7, 2022 05:18
ShooterIT added a commit to ShooterIT/kvrocks that referenced this pull request Jan 27, 2022
Currently, we can't execute INFO command during restoring database on kvrocks,
but redis can. Kvrocks returns error messages directly, it is not easy for some
SDK/proxy/tools to check loading or other status, so this commit implements.
@ShooterIT ShooterIT mentioned this pull request Jan 27, 2022
ShooterIT added a commit to ShooterIT/kvrocks that referenced this pull request Jan 28, 2022
Currently, we can't execute INFO command during restoring database on kvrocks,
but redis can. Kvrocks returns error messages directly, it is not easy for some
SDK/proxy/tools to check loading or other status, so this commit implements.
ShooterIT added a commit that referenced this pull request Jan 28, 2022
Currently, we can't execute INFO command during restoring database on kvrocks,
but redis can. Kvrocks returns error messages directly, it is not easy for some
SDK/proxy/tools to check loading or other status, so this commit implements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants