Improve the description of Perflog in default config file #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caipengbo really good to make the perflog description more clearly. The unit test failure should be caused by the empty perf command string which we didn't ignore. |
|
The reason about UT failed is that I forgot to call |
git-hulk
previously approved these changes
Oct 22, 2021
git-hulk
reviewed
Oct 22, 2021
git-hulk
previously approved these changes
Oct 22, 2021
ShooterIT
reviewed
Oct 22, 2021
ShooterIT
approved these changes
Oct 22, 2021
git-hulk
approved these changes
Oct 22, 2021
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Nov 2, 2021
ShooterIT
pushed a commit
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
profiling-sample-commandsconfig item and some comments aboutPERFLOGin the default config file.This will help users understand how to use
PERFLOGto troubleshoot their performance problems.I also checked the
profiling- samp-commandsin code logic, which will returns an error if a command is not supported by Kvrocks. And fixed a small bug aboutstats_dump_period_secconfig item.