Add write stall stats to info command output #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
reviewed
Nov 19, 2021
Co-authored-by: Wang Yuan <wangyuancode@163.com>
@ShooterIT I don't think it's necessary to add If we all add it, we'll have too much information. |
|
fine, both are ok to me |
ShooterIT
approved these changes
Nov 19, 2021
git-hulk
approved these changes
Nov 19, 2021
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Wang Yuan <wangyuancode@163.com>
Merged
ShooterIT
added a commit
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Wang Yuan <wangyuancode@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kvrocks uses RocksDB as the storage engine. When RocksDB can't flush and compact data promptly, it uses a feature called " Write Stalls" to try and slow the amount of data coming into the engine.
This is information user should know. Currently, Kvrocks uses RocksDB's EventListener mechanism to capture stall information. The user must grep the log to get this information.
So I add it to the output of the
INFOcommand so that users can get information from theINFOcommand directly. It can also be easily applied to their monitor systems.