Fix config rewrite overwrite the first rename-command with the last one #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, we have below rename-commands in the config file: ``` rename-command KEYS KEYS_NEW rename-command GET GET_NEW rename-command SET SET_NEW ``` then `rename-command KEYS KEYS_NEW` would be overwriten to `rename-command SET SET_NEW` since we didn't skip the `rename-command` correctly in config rewrite.
|
tcl tests config |
ShooterIT
approved these changes
Dec 16, 2021
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 27, 2022
…ne (apache#429) For example, we have below rename-commands in the config file: ``` rename-command KEYS KEYS_NEW rename-command GET GET_NEW rename-command SET SET_NEW ``` then `rename-command KEYS KEYS_NEW` would be overwriten to `rename-command SET SET_NEW` since we didn't skip the `rename-command` correctly in config rewrite.
Merged
ShooterIT
pushed a commit
that referenced
this pull request
Jan 28, 2022
…ne (#429) For example, we have below rename-commands in the config file: ``` rename-command KEYS KEYS_NEW rename-command GET GET_NEW rename-command SET SET_NEW ``` then `rename-command KEYS KEYS_NEW` would be overwriten to `rename-command SET SET_NEW` since we didn't skip the `rename-command` correctly in config rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, we have below rename-commands in the config file:
then
rename-command KEYS KEYS_NEWwould be overwriten torename-command SET SET_NEWsince we didn't skip therename-commandcorrectly in config rewrite.
Closes #428