Support to convert sortedint type to zset type in kvrocks2redis #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kRedisSortedint metadata type 7 out of range
caipengbo
reviewed
Dec 19, 2021
Co-authored-by: Myth <caipengbo@outlook.com>
ShooterIT
requested changes
Dec 21, 2021
caipengbo
reviewed
Dec 21, 2021
Co-authored-by: Myth <caipengbo@outlook.com>
caipengbo
reviewed
Dec 21, 2021
Co-authored-by: Myth <caipengbo@outlook.com>
ShooterIT
changed the title
|
thanks @fishery86 currently code also is fine to me. But there are remaining jobs after merging
could you do these jobs? @fishery86 or @caipengbo |
ShooterIT
approved these changes
Dec 22, 2021
|
I'm going to do that in the near future. |
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 27, 2022
…he#431) Co-authored-by: Myth <caipengbo@outlook.com>
Merged
ShooterIT
pushed a commit
that referenced
this pull request
Jan 28, 2022
Co-authored-by: Myth <caipengbo@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covert sortint to sorted set