Optimize the seek of RocksDB iterators #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
approved these changes
Dec 30, 2021
git-hulk
approved these changes
Dec 30, 2021
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 27, 2022
RocksDB iterator seek slows down dramatically when there are many large deleted rows. This slow down persists until a compaction occurs. To set read_options.iterate_upper_bound as tight as possible is recommended, so that internal iterating can stop sooner, rather than walking over the whole range of tombstones. Similarly, setting read_options.iterate_lower_bound for seekForPrev is recommended too. Relevant RocksDB issue: facebook/rocksdb#5265
Merged
ShooterIT
pushed a commit
that referenced
this pull request
Jan 28, 2022
RocksDB iterator seek slows down dramatically when there are many large deleted rows. This slow down persists until a compaction occurs. To set read_options.iterate_upper_bound as tight as possible is recommended, so that internal iterating can stop sooner, rather than walking over the whole range of tombstones. Similarly, setting read_options.iterate_lower_bound for seekForPrev is recommended too. Relevant RocksDB issue: facebook/rocksdb#5265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocksDB iterator seek slows down dramatically when there are many large deleted rows. This slow down persists until a compaction occurs. To set read_options.iterate_upper_bound as tight as possible is recommended, so that internal iterating can stop sooner, rather than walking over the whole range of tombstones. Similarly, setting read_options.iterate_lower_bound for seekForPrev is recommended too.
Relevant RocksDB issue: facebook/rocksdb#5265