Fix the bitmap range is smaller than that of Redis #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
reviewed
Jan 19, 2022
git-hulk
approved these changes
Jan 20, 2022
ShooterIT
approved these changes
Jan 22, 2022
|
Merged, thanks @ColinChamber |
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 27, 2022
Merged
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jan 28, 2022
ShooterIT
pushed a commit
that referenced
this pull request
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background in issue #454, I originally planned to expand the permitted range of
start endparameters ofbitcount bitopto be the same as in Redis. But, I found that there were too many changes, and it was unnecessary to do that because the offset of setbit is at most2^32-1. So it remainsstd::stoidoesn't seem to be a problem after the fix because start/end is different from offset, one is byte, and the other is bit.closes #454