Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid requirepass and masterauth conflicts with the namespace tokens #507

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

caipengbo
Copy link
Contributor

If requirepass and masterauth are duplicated with namespace tokens, the AUTH command cannot be executed correctly. So we should avoid conflicts between them.

src/config.cc Show resolved Hide resolved
@caipengbo caipengbo requested review from git-hulk and ShooterIT March 5, 2022 08:46
src/config.cc Show resolved Hide resolved
@caipengbo caipengbo requested a review from git-hulk March 13, 2022 01:56
src/config_type.h Outdated Show resolved Hide resolved
src/config.cc Show resolved Hide resolved
@caipengbo caipengbo requested a review from git-hulk March 18, 2022 03:06
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit 4cd4bb9 into apache:unstable Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants