Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return bulk string (instead of array) when spop without count. #515

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix: return bulk string (instead of array) when spop without count. #515

merged 1 commit into from
Mar 8, 2022

Conversation

patpatbear
Copy link
Contributor

kvrocks spop reply array.
redis spop reply:

  • bulk string(or nil) when spop without count
  • array when spop with count

this patch fix kvrocks spop reply without count.

@git-hulk git-hulk requested review from ShooterIT and git-hulk March 8, 2022 11:09
@git-hulk git-hulk added the bug type bug label Mar 8, 2022
@git-hulk
Copy link
Member

git-hulk commented Mar 8, 2022

@patpatbear Thanks for your contribution, cheers!

@git-hulk git-hulk merged commit 72f3c3c into apache:unstable Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShooterIT ShooterIT ShooterIT approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
bug type bug release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patpatbear @git-hulk @ShooterIT