Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for listening to unix socket #531

Merged
merged 2 commits into from
May 7, 2022
Merged

Add support for listening to unix socket #531

merged 2 commits into from
May 7, 2022

Conversation

torwig
Copy link
Contributor

@torwig torwig commented Mar 30, 2022

Two (or more) threads/processes cannot bind (and listen) to the same Unix socket:
https://unix.stackexchange.com/questions/615330/what-happens-when-two-processes-listen-on-the-same-berkeley-unix-file-socket.
That's why only one Worker binds the socket.
Introduce a separate ConfigField and a function to parse Unix socket permissions from the config file. This number is defined
in octal form (e.g. 770 or 0777).

@torwig
Add support for listening to unix socket (apache#148)
abe08e4 
Two processes cannot bind (and listen) to the same unix socket.
That's why only one Worker binds the socket.
Introduce a separate ConfigField and function to parse
unix socket permissions from config file. This number is defined
in octal form (e.g. 770 or 0777).
@git-hulk
Copy link
Member

Cool, thanks for your great contribution!

@git-hulk git-hulk requested review from git-hulk and ShooterIT March 30, 2022 14:00
@git-hulk git-hulk added feature type new feature release notes labels Mar 30, 2022
git-hulk
git-hulk approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk
Copy link
Member

git-hulk commented Apr 1, 2022

@torwig Thanks for your great contribution again, we are planning to donate Kvrocks to ASF recently, so this PR would be pending before that. We also had filed the issue to let every contributor know and agree. For more detail can see: #530

@ShooterIT
Copy link
Member

Thanks @torwig LGTM.
Are you familiar with TCL? please add test cases if yes, if no, i will do that in the next PR.

@torwig
Copy link
Contributor Author

torwig commented May 7, 2022

Hi @ShooterIT , I'm not familiar with TCL right now.

@ShooterIT ShooterIT linked an issue May 7, 2022 that may be closed by this pull request
Please support unix domain socket #148
Closed
@ShooterIT ShooterIT changed the title Add support for listening to unix socket (#148) Add support for listening to unix socket May 7, 2022
@ShooterIT ShooterIT merged commit f4c517b into apache:unstable May 7, 2022
@ShooterIT
Copy link
Member

@torwig fine, i merged, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShooterIT ShooterIT ShooterIT approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
feature type new feature release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support unix domain socket
3 participants
@torwig @git-hulk @ShooterIT