-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove handwritten makefiles to keep only one build system #576
Conversation
@PragmaTwice we may still keep some targets in Makefile such as lints to running checker. In a separated pass we can consider whether adopt Makefile to do such job or port them in scripts or other approaches. NOTICE: CI failed because of |
I think Hence I consider to remove the target to delete all Makefiles to make sure these handwritten makefiles will not conflict with cmake-generated makefiles (i.e. call |
@PragmaTwice thanks for your investigation! SGTM do the replacement since it's trivial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I like this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool job, it is much clear, thanks!
There are many bug reports about linking snappy when using make
, i think this PR can also resolve this problem.
Merging... |
@PragmaTwice thanks for your contribution! |
This resolves #574.