Fix the slave may crash when restoring the db #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The db pointer was forbidden to use when restoing the db, but we didn't check the loading status in `recordInstantaneousMetrics` in the server's cron thread. We can skip all the cron operations when restoring the db instead of checking status one by one.
ShooterIT
approved these changes
May 25, 2022
ShooterIT
reviewed
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The db pointer was forbidden to use when restoring the db, but we
didn't check the loading status in
recordInstantaneousMetricsin the server's cron thread. We can skip all the cron operations
when restoring the db instead of checking status one by one.
This closes #603