Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build static lib of glog in CMake #618

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Build static lib of glog in CMake #618

merged 1 commit into from
Jun 4, 2022

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Jun 3, 2022 •
edited
Loading

Fix #615.

After this PR (liblzma.so is brought in by libunwind.so):

$ ldd kvrocks
        linux-vdso.so.1 (0x00007fff165d7000)
        libunwind.so.8 => /usr/lib/libunwind.so.8 (0x00007fa86a7ae000)
        libm.so.6 => /usr/lib/libm.so.6 (0x00007fa86a6c6000)
        libc.so.6 => /usr/lib/libc.so.6 (0x00007fa86a4bc000)
        /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007fa86b8d8000)
        liblzma.so.5 => /usr/lib/liblzma.so.5 (0x00007fa86a493000)
        libpthread.so.0 => /usr/lib/libpthread.so.0 (0x00007fa86a48e000)

tisonkun
tisonkun reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Comments inline.

CMakeLists.txt Show resolved Hide resolved
@tisonkun
Copy link
Member

tisonkun commented Jun 4, 2022

Merging...

FWIW a discussion (#615) cannot be resolved. You may create an issue from the discussion the next time.

@tisonkun tisonkun merged commit 65778a1 into apache:unstable Jun 4, 2022
@PragmaTwice
Copy link
Member Author

Merging...

FWIW a discussion (#615) cannot be resolved. You may create an issue from the discussion the next time.

My mistake, will open an issue next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @tisonkun @git-hulk