Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: not call GetCurrentTime when possible #709

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jul 3, 2022

Note: this merge request will regard expire <= 0 as "not has expire", maybe break the constraint before.

This mr solves issue #708

@git-hulk git-hulk self-requested a review July 3, 2022 09:47
@mapleFU
Copy link
Member Author

mapleFU commented Jul 3, 2022

ASAN:DEADLYSIGNAL
=================================================================
==30388==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000000f0 (pc 0x55c5e3f1823b bp 0x7fb31cbe58b0 sp 0x7fb31cbe5888 T103)
==30388==The signal is caused by a READ memory access.
==30388==Hint: address points to the zero page.

emmm, does this caused by my commits? No idea why this occurs

@git-hulk
Copy link
Member

git-hulk commented Jul 3, 2022

ASAN:DEADLYSIGNAL

==30388==ERROR: AddressSanitizer: SEGV on unknown address 0x0000000000f0 (pc 0x55c5e3f1823b bp 0x7fb31cbe58b0 sp 0x7fb31cbe5888 T103)
==30388==The signal is caused by a READ memory access.
==30388==Hint: address points to the zero page.

emmm, does this caused by my commits? No idea why this occurs

Yes, this failure isn't related to current PR, will record the stack and rerun CI.

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapleFU
Copy link
Member Author

mapleFU commented Jul 3, 2022

Yes, this failure isn't related to current PR, will record the stack and rerun CI.

It might be some concurrency problems on shutdown, since 0x0000000000f0 is a strange address.

@tisonkun
Copy link
Member

tisonkun commented Jul 4, 2022

This mr solves issue #709

@mapleFU there is no "issue" #709 .

@mapleFU
Copy link
Member Author

mapleFU commented Jul 4, 2022

@mapleFU there is no "issue" #709 .

So sorry for making the mistake, I have update it to #708. PTAL

@mapleFU
Copy link
Member Author

mapleFU commented Jul 5, 2022

I think it's from redis: https://redis.io/commands/ttl/ @tisonkun

We can use a enum to represent them

@git-hulk
Copy link
Member

git-hulk commented Jul 5, 2022

Thanks all, merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants