-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: not call GetCurrentTime when possible #709
Conversation
emmm, does this caused by my commits? No idea why this occurs |
Yes, this failure isn't related to current PR, will record the stack and rerun CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It might be some concurrency problems on shutdown, since |
I think it's from redis: https://redis.io/commands/ttl/ @tisonkun We can use a enum to represent them |
Thanks all, merging... |
Note: this merge request will regard
expire <= 0
as "not has expire", maybe break the constraint before.This mr solves issue #708